Closed igorandreoni closed 3 years ago
To be clear, the only thing that really must be fixed before merging is the import, as this will break things for other users. I would really like the renaming of 'getLc' to reduce confusion. The other items are suggestions.
Thank you for the great feedback, Lynne! I implemented all your suggestions (barred one that I am not sure about). I am working on the unit test, thanks for sending the link to an example. I committed the other changes in the meantime, since it may take a bit longer to create a sensible unit test.
This pull request includes all the changes that I have developed in the last few weeks for the kilonova metric, based on your TDE metric and Michael Coughlin's initial modifications. It already includes the fixing of the dust extinction bug. Apologies if this pull request is a bit heavy, future ones should be way smaller. I left two # FIXME at the top because I haven't managed to test those two lines that I suggest to bring back in (they are currently commented out).