LSSTDESC / BlendingToolKit

Tools to create blend catalogs, produce training samples and implement blending metrics
https://lsstdesc.org/BlendingToolKit/index.html
MIT License
28 stars 11 forks source link

Create fits files #465

Closed pecom closed 8 months ago

pecom commented 12 months ago

Adds functionality to save blended/deblended batches as FITS files.

codecov[bot] commented 12 months ago

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (cef8222) 61.15% compared to head (ed30853) 57.96%. Report is 1 commits behind head on dev.

Files Patch % Lines
btk/blend_batch.py 9.70% 93 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #465 +/- ## ========================================== - Coverage 61.15% 57.96% -3.20% ========================================== Files 19 19 Lines 1555 1658 +103 ========================================== + Hits 951 961 +10 - Misses 604 697 +93 ``` | [Flag](https://app.codecov.io/gh/LSSTDESC/BlendingToolKit/pull/465/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LSSTDESC/BlendingToolKit/pull/465/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | `57.96% <9.70%> (-3.20%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ismael-mendoza commented 11 months ago

another question @pecom is the saving and loading with fits files useful to you for the DeblendBatch ? If not I would suggest not including it

ismael-mendoza commented 8 months ago

@pecom I'm closing this for now, is it finished? feel free to let me know or re-open if you are still interested