LSSTDESC / BlendingToolKit

Tools to create blend catalogs, produce training samples and implement blending metrics
https://lsstdesc.org/BlendingToolKit/index.html
MIT License
28 stars 11 forks source link

Last few tweaks to the quickstart & advanced-analysis tutorial #477

Closed ismael-mendoza closed 5 months ago

ismael-mendoza commented 7 months ago

This PR will adjust the following two notebooks so they are ready to be released alongside the BTK paper:

In advanced-analysis, I'm also tidying up the plots to be "paper-ready". Other todo items:

In the end, when looking into the above to-do item I discovered some bugs in the matching procedure. So I'm fixing them here too.

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 24.07407% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 62.76%. Comparing base (180bf61) to head (cead309).

:exclamation: Current head cead309 differs from pull request most recent head 655ce30. Consider uploading reports for the commit 655ce30 to get more accurate results

Files Patch % Lines
btk/match.py 33.33% 22 Missing :warning:
btk/measure.py 13.33% 13 Missing :warning:
btk/deblend.py 0.00% 5 Missing :warning:
btk/plotting.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #477 +/- ## ========================================== - Coverage 63.90% 62.76% -1.14% ========================================== Files 19 19 Lines 1568 1598 +30 ========================================== + Hits 1002 1003 +1 - Misses 566 595 +29 ``` | [Flag](https://app.codecov.io/gh/LSSTDESC/BlendingToolKit/pull/477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LSSTDESC/BlendingToolKit/pull/477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | `62.76% <24.07%> (-1.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.