LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy
BSD 3-Clause "New" or "Revised" License
145 stars 68 forks source link

Emu pk #1094

Closed matteozennaro closed 1 year ago

matteozennaro commented 1 year ago

Enable passing linear and nonlinear pk emulators to the cosmology class (baccoemu and euclid emulator 2 implemented for now, generic emulator class introduced extendable to other emulators). Added baccoemu baryonic effect emulator to baryons class.

damonge commented 1 year ago

@matteozennaro flake8 is failing (from experience, best run this on your machine before pushing). Do flake8 pyccl/ and flake8 benchmarks/ and solve all the issues that pop up.

damonge commented 1 year ago

The tests are failing because they can't import baccoemu. Try getting it to install by adding it here: https://github.com/LSSTDESC/CCL/blob/master/.github/environment.yml

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5510615878


Changes Missing Coverage Covered Lines Changed/Added Lines %
pyccl/baryons/baccoemu_baryons.py 64 65 98.46%
pyccl/emulators/baccoemu_linear_pk.py 53 54 98.15%
pyccl/emulators/baccoemu_nonlinear_pk.py 48 49 97.96%
<!-- Total: 197 200 98.5% -->
Totals Coverage Status
Change from base Build 5199196746: 0.04%
Covered Lines: 5318
Relevant Lines: 5450

💛 - Coveralls
hsinfan1996 commented 1 year ago

May be related https://github.com/lesgourg/class_public/issues/416