search

LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy
BSD 3-Clause "New" or "Revised" License
145 stars 68 forks source link

Inconsistent naming of BaccoEmu Baryons object #1125

Closed damonge closed 6 months ago

damonge commented 1 year ago

The BaccoemuBaryons object should be called BaryonsBaccoemu to conform with the naming of other baryonic effect objects (e.g. BaryonsSchneider15 or BaryonsVanDaalen19).

Unfortunately this slipped through after tagging v3, and changing it would break the API. Thoughts?

damonge commented 1 year ago

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

nikosarcevic commented 1 year ago

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

I would suggest naming it "BaryonsArico20" to keep consistent with other modules.

zdu863 commented 7 months ago

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

Do we need to create separate unit tests for the deprecated class?