Closed hsinfan1996 closed 10 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pyccl/baryons/baryons_base.py | 1 | 88.89% | ||
pyccl/emulators/emu_base.py | 2 | 81.82% | ||
pyccl/halos/concentration/constant.py | 4 | 71.43% | ||
pyccl/halos/concentration/klypin11.py | 4 | 66.67% | ||
pyccl/halos/concentration/duffy08.py | 6 | 60.0% | ||
pyccl/halos/hmfunc/jenkins01.py | 6 | 62.5% | ||
pyccl/halos/hmfunc/press74.py | 6 | 60.0% | ||
pyccl/halos/hmfunc/angulo12.py | 7 | 58.82% | ||
pyccl/power.py | 8 | 84.62% | ||
pyccl/halos/concentration/bhattacharya13.py | 9 | 50.0% | ||
<!-- | Total: | 4089 | --> |
Totals | |
---|---|
Change from base Build 6769057346: | -64.8% |
Covered Lines: | 2054 |
Relevant Lines: | 6309 |
Hi @hsinfan1996. As a workaround, I increased the tolerance in #869 (see this commit: https://github.com/LSSTDESC/CCL/pull/869/commits/2b323eafe83dd989aafd067aac3bd788980c4889). With it both ubuntu and mac tests passed.
Hi @hsinfan1996. As a workaround, I increased the tolerance in #869 (see this commit: 2b323ea). With it both ubuntu and mac tests passed.
Thanks. Yes, I think for now increasing the tolerance is the only way.
Just so we're clear, what is the issue exactly? Is it that mac uses a different gsl or something like that compared to python on GHA?
I still don't know caused the tests on macOS to fail. Amongst the packages common to the two platforms, the differences I can spot are the compilers and libgfortran-related packages. macOS uses libgfortran-devel_osx-64=12.2.0
while Ubuntu uses libgfortran5=13.2.0
.
Oh well... I'd be happy to just raise the tolerance and add a comment documented that this is because of mac on GHA (in case we can bring it back down in the future)
Why CI is failing on macOS during unit tests but not on Ubuntu?