search

LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy
BSD 3-Clause "New" or "Revised" License
145 stars 64 forks source link

typo in correlation method #1132

Closed nikosarcevic closed 11 months ago

nikosarcevic commented 11 months ago

not sure if this typo is still in ccl v3 but im running v2.8 and found this typo

correlation(cosmo, ell, C_ell, theta, type, corr_type, method) 137 method = method.lower() 139 if type not in correlation_types: --> 140 raise ValueError(f"Invalud correlation type {type}.") 142 if method not in correlation_methods.keys(): 143 raise ValueError(f"Invalid correlation method {method}.")

"Invalud"
damonge commented 11 months ago

I kind of like "Invalud" :-P.

Thanks for spotting this. Do you mind fixing it here https://github.com/LSSTDESC/CCL/pull/1122 ? It's not really a documentation bug, but also not worth triggering a new PR for it.

nikosarcevic commented 11 months ago

I kind of like "Invalud" :-P. it is pretty cool 😂😂😂

Thanks for spotting this. Do you mind fixing it here #1122 ? It's not really a documentation bug, but also not worth triggering a new PR for it. no problem, ill fix it 😎

nikosarcevic commented 11 months ago

DONE.