Open RyoTerasawa opened 11 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pyccl/halos/hmfunc/darkemulator.py | 36 | 38 | 94.74% | ||
pyccl/pkresponse.py | 301 | 347 | 86.74% | ||
<!-- | Total: | 339 | 387 | 87.6% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pyccl/_core/parameters/fftlog_params.py | 1 | 97.06% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 9566319765: | -0.5% |
Covered Lines: | 6900 |
Relevant Lines: | 7120 |
@RyoTerasawa can I check what the status of this PR is?
I am waiting for someone to review the code. I haven't asked for a specific person yet, but maybe I should ask a member of the MCPCov group to review it. I am happy to explain the details if needed. I am also working on writing the unit test and benchmark test to be included in this PR.
@RyoTerasawa @YueNan-c, maybe you want to also implement the DarkEmulator here: https://github.com/LSSTDESC/CCL/blob/master/pyccl/emulators/cosmicemu_pk.py.
Are the unit tests and benchmark ready?
@RyoTerasawa @carlosggarcia can I check what the status of this is?
@carlosggarcia @damonge Sorry for the late reply. I just added the unit tests and benchmark, and this pull request is ready to be reviewed.
In pyccl/pkresponse.py, I implemented the functions to calculate power spectrum responses to the super-survey modes which are responsible for super-sample covariance (SSC), based on arXiv:2310.13330. We approximate the power spectrum growth response to the super-survey modes by its growth response to the Hubble parameter.
For the galaxy-matter and galaxy-auto power spectra, the halo statistics (halo-matter/halo-auto power spectrum, mass function) are calculated by DarkEmulator.