Background Calculations

LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy

BSD 3-Clause "New" or "Revised" License

133 stars 64 forks source link

Background Calculations #1149

Closed hsinfan1996 closed 6 months ago

hsinfan1996 commented 6 months ago

Merge distances_v3 branch into master (different from PR #1066 ). Closes issue #954 andd #408 .

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 7387466258

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 97.463%

Totals
Change from base Build 7020570041:	0.02%
Covered Lines:	6532
Relevant Lines:	6702

💛 - Coveralls

hsinfan1996 commented 6 months ago

@nikosarcevic I've done merging the master branch into the revived distances_v3. Now you can try the new functions and see if the calculations are correct and maybe modify the code if you want.

damonge commented 6 months ago

@hsinfan1996 let me know when you'd like me to review this. Right now I see the tests are still failing, but happy to help.

hsinfan1996 commented 6 months ago

@damonge This is ready for review. Is there a way to fix the tests on macOS? I don't know why sometimes they passed but sometimes not.

hsinfan1996 commented 6 months ago

@damonge This is ready for review. Is there a way to fix the tests on macOS? I don't know why sometimes they passed but sometimes not.

From my observation, faster test runs on macOS (typically < 25 min) will pass, slower ones (~35 min) will not. The weird thing is that the failed tests are not timed, but it is good that the problem is not likely caused by our code.