Fix GHA on macOS - Githubissues

LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy

BSD 3-Clause "New" or "Revised" License

145 stars 64 forks source link

Fix GHA on macOS #1154

Closed hsinfan1996 closed 7 months ago

hsinfan1996 commented 7 months ago

Fix GHA

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7821325595

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.463%

Totals
Change from base Build 7413512341:	0.0%
Covered Lines:	6532
Relevant Lines:	6702

💛 - Coveralls

hsinfan1996 commented 7 months ago

llvm-openmp is what I want to fix here. fftw was installed from source by cmake, and now it is moved to conda.

tilmantroester commented 7 months ago

Looks good to me but do you understand why removing llvm-openmp fixes the openmp errors?

hsinfan1996 commented 7 months ago

Looks good to me but do you understand why removing llvm-openmp fixes the openmp errors?

I don't remember why it was installed separately, and only for macOS (maybe because on ubuntu the behavior was different). Now llvm-openmp is installed automatically along with other environment packages, so it is still there.