LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy
BSD 3-Clause "New" or "Revised" License
145 stars 64 forks source link

Fix unit tests on macOS #1178

Closed hsinfan1996 closed 4 months ago

hsinfan1996 commented 4 months ago

Fix a warning on ambiguous package distribution. (Installing with develop mode "-e" will not see the warning.)

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9017026807

Details


Totals Coverage Status
Change from base Build 9013762215: 0.0%
Covered Lines: 6556
Relevant Lines: 6727

💛 - Coveralls
hsinfan1996 commented 4 months ago

Somehow this PR also fixes unit tests on macOS.

hsinfan1996 commented 4 months ago

To suppress other warnings, we should turn to PR #1144, which I think is ready for review.

damonge commented 4 months ago

@hsinfan1996 thanks for this. #1144 is merged, and I can review this as soon as conflicts are resolved.

hsinfan1996 commented 4 months ago

I was going to make this PR a final fix to setup.py before we merge PR #1144. But it is still good to just fix the unit tests on macOS.

hsinfan1996 commented 4 months ago

@damonge Thank you. This PR is ready for review. For the changes in pyproject.toml, I only move the item up to make it more visible. Interestingly, CI on macOS now runs faster than on Ubuntu. (It was WAYYY slower.)