Function fixed: comoving_volume_element

LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy

BSD 3-Clause "New" or "Revised" License

145 stars 64 forks source link

Function fixed: comoving_volume_element #1181

Closed pennalima closed 4 months ago

pennalima commented 4 months ago

Previous implementation was using the comoving_angular_distance. Fix to use the angular_diameter_diatance.

hsinfan1996 commented 4 months ago

What about this line? https://github.com/LSSTDESC/CCL/blob/d762d995d9edb23522ff42818aa2343af3ec2d34/pyccl/background.py#L311

damonge commented 4 months ago

@pennalima I think the function was correct as it was. Note that the function is meant to be dV / (da dOmega), not dV / (dz dOmega), which is maybe what you were thinking.

pennalima commented 4 months ago

Hi @hsinfan1996,

Thanks a lot! Yes, I was reading it as dV/(dzdOmega). So, we can ignore it.

damonge commented 4 months ago

Ok, thanks! I'll close this then.