LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy
BSD 3-Clause "New" or "Revised" License
145 stars 68 forks source link

Add CMB predictions #428

Closed elisachisari closed 3 years ago

elisachisari commented 6 years ago

Add CMB observables beyond lensing to CCL, as combined probed analyses form LSST will include them. These predictions can be directly output from CLASS, we just need to link them in the right way.

Suggested by @dodelson.

dodelson commented 6 years ago

Wow, what fast service! I'm hooked

Sent from my iPhone

On Jul 24, 2018, at 4:34 PM, elisachisari notifications@github.com<mailto:notifications@github.com> wrote:

Add CMB observables beyond lensing to CCL, as combined probed analyses form LSST will include them. These predictions can be directly output from CLASS, we just need to link them in the right way.

Suggested by @dodelsonhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dodelson&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=1sg686L92HgxpQF5wXl0sz3VthEo02F_vNwrcDNjAdw&m=mz9PISEH4bywwH-449ByuSORjo43BfgDoCwABUhq93U&s=c0DxnN2Lo-ORngMD0Ef0nxpPPnC5_GgcsaW6TkVcDsE&e=.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LSSTDESC_CCL_issues_428&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=1sg686L92HgxpQF5wXl0sz3VthEo02F_vNwrcDNjAdw&m=mz9PISEH4bywwH-449ByuSORjo43BfgDoCwABUhq93U&s=8GA7s7PvcHKRYiac8A7xBFKG_mUsSSkTLVPuSMO-6S0&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKP8XGbD32Rsrz3ingoR8wIfISmujmYyks5uJ4S2gaJpZM4VeQI8&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=1sg686L92HgxpQF5wXl0sz3VthEo02F_vNwrcDNjAdw&m=mz9PISEH4bywwH-449ByuSORjo43BfgDoCwABUhq93U&s=DkAuI9y3PydQRUvNvToCIT3vpPIBPk-w5SUdKgCSiqc&e=.

villarrealas commented 6 years ago

Should we also seek to offer something more general than CLASS, given we are moving away from that as a core dependency? I do not do CMB work, so I am uncertain how feasible this is.

Not to say I don't like the quick CLASS linking as a step one.

damonge commented 6 years ago

I think for CMB primary that's perfectly fine. The only thing we would probably want to add explicitly in CCL are auto- and cross-correlations with the secondary anisotropies (ISW, tSZ, kSZ, maybe CIB? CMB lensing is already there)

dodelson commented 6 years ago

It might be useful at this early stage to consider timing. In des chains, we are having problems running with cmb as each sample can take up to 20 sec

Sent from my iPhone

On Jul 24, 2018, at 4:52 PM, David Alonso notifications@github.com<mailto:notifications@github.com> wrote:

I think for CMB primary that's perfectly fine. The only thing we would probably want to add explicitly in CCL are auto- and cross-correlations with the secondary anisotropies (ISW, tSZ, kSZ, maybe CIB? CMB lensing is already there)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LSSTDESC_CCL_issues_428-23issuecomment-2D407548045&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=1sg686L92HgxpQF5wXl0sz3VthEo02F_vNwrcDNjAdw&m=uSjOYU3gF4LjGG5e4IbVxUtdtaKhAUk-Tt_J64KSSeI&s=Lejg-jcvh7_vP_rRNxlv1qkBzE13RNn5XNCJQBK8ehI&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKP8XLZRsg7f97-5FW0Hap-2D9JKfTH7izVTks5uJ4kMgaJpZM4VeQI8&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=1sg686L92HgxpQF5wXl0sz3VthEo02F_vNwrcDNjAdw&m=uSjOYU3gF4LjGG5e4IbVxUtdtaKhAUk-Tt_J64KSSeI&s=viLtQeOeEIb0Xlnlbmh3PifnJDh9kENR8vtjm34KBfE&e=.

damonge commented 6 years ago

Mmh, is this because you're asking for both CMB and P(k) at low z at the same time and it takes too long to solve the perturbation equations? Otherwise CMB people should encounter the same issues, I guess.

dodelson commented 6 years ago

Yes i think you're right, and part of solving that is choosing settings in, e.g. Camb optimally

Sent from my iPhone

On Jul 24, 2018, at 4:57 PM, David Alonso notifications@github.com<mailto:notifications@github.com> wrote:

Mmh, is this because you're asking for both CMB and P(k) at low z at the same time and it takes too long to solve the perturbation equations? Otherwise CMB people should encounter the same issues, I guess.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_LSSTDESC_CCL_issues_428-23issuecomment-2D407549645&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=1sg686L92HgxpQF5wXl0sz3VthEo02F_vNwrcDNjAdw&m=RC4mfwuSjhHBU6J7QMLAcOC6bEP9drntT87TFhrk5jQ&s=Tggqav5RX3k17mTF4X93MXVf_9aMijGho6q1Sl_LyVk&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKP8XGoAPsxL-5FCkewCokNh8ReQj81A5Wks5uJ4pDgaJpZM4VeQI8&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=1sg686L92HgxpQF5wXl0sz3VthEo02F_vNwrcDNjAdw&m=RC4mfwuSjhHBU6J7QMLAcOC6bEP9drntT87TFhrk5jQ&s=J95vvnBfJC4ASMXoZIsJ2ZntuwF4xAojTb_MNPELf3I&e=.

beckermr commented 5 years ago

Reupping this issue. We discussed this in the context of firecrown a bit today. The basic options are to

  1. Enable CCL to produce the proper CMB predictions.
  2. Only call CLASS from python outside of CCL and then feed the things we need back into CCL. This relates to the 2D power spectrum work @damonge is doing in #511
c-d-leonard commented 4 years ago

This issue is currently being worked on by @chrgeorgiou , first PR #739 in progress

beckermr commented 4 years ago

What is the plan here?

If you are going to input distances etc from CLASS or CAMB, you should know that these are being called in python now. So instead of making a bunch of new arguments to the Cosmology object, you should have a single switch that says to use the boltzmann code produced quantities.

beckermr commented 4 years ago

@chrgeorgiou @damonge

c-d-leonard commented 4 years ago

Yeah, from my understanding of what Christos is doing it's not to make a bunch of new arguments but more like a single switch like you said, but he can clarify more.

chrgeorgiou commented 4 years ago

The main idea of my work is to split the theory calculations and observables calculations of CCL into two distinct parts, so that if someone wants to calculate only observable quantities he can do so without having the need to define a cosmology. The ultimate goal is to be able to use CCL with the Cobaya sampler, without having to go through CCL's theory calculations. For more information you can ask David-Alonso or Antony Lewis.

This would not change the functionality of CCL but simply extend it.

beckermr commented 4 years ago

I don't follow @chrgeorgiou.

beckermr commented 4 years ago

However, the proliferation of arguments to the Cosmology object in your PR is problematic for sure.

damonge commented 4 years ago

We can discuss this in detail in the next telecon, but I think this is the right way to go. We may want to create a separate constructor for cosmologies that receive distances/growth/pks directly, but I wouldn't tie things solely to the two boltzmann solvers we have right now, since the whole point of this is to make CCL cosmology-agnostic when needed.

damonge commented 4 years ago

(this is also off-topic with regards to the point of this issue, BTW. Christos hasn't started implementing this yet, and it will be done in a different PR).

beckermr commented 4 years ago

Ahhh ok. I am totally fine with creating a small number of classes, say 2, to support this.

c-d-leonard commented 3 years ago

@damonge would we say this issue is resolved at this point?

damonge commented 3 years ago

I think so. We don't need CCL to return CMB-only power spectra. There are cross-correlations we will want to compute (e.g. ISW), but those are already in the making.