search

LSSTDESC / CCL

DESC Core Cosmology Library: cosmology routines with validated numerical accuracy
BSD 3-Clause "New" or "Revised" License
144 stars 64 forks source link

BBKS bug #591

Closed beckermr closed 5 years ago

beckermr commented 5 years ago

from @vitenti

In the BBKS formula in CCL the definition of "q" seems to be missing a factor of (T_0/2.7K)^2 [Eq. 3.9 Sugiyama 1995], anyway, we create a CCL "compatibility mode" for our BBKS which uses the same definition of "q" as CCL and the tests went through, we agree in 5 x 10^-5 (which increases as we include more knots in CCL splines). In these tests we also included the comparison between basic background quantities as Omegas, H/H0 and growth function. (We can breakdown these number in the future to get the largest error in redshift per observable)

beckermr commented 5 years ago

Who uses BBKS? Can we simply get rid of this option?

damonge commented 5 years ago

Fixing in #526

damonge commented 5 years ago

Fixed by #526

beckermr commented 5 years ago

A fix needs to be put on the v1x branch too

damonge commented 5 years ago

ok, just made a PR