Issue/552/improve 2h functions

LSSTDESC / CLMM

A Python library for performing galaxy cluster mass reconstruction from weak lensing observables

BSD 3-Clause "New" or "Revised" License

24 stars 20 forks source link

Issue/552/improve 2h functions #575

Closed rancesol closed 1 year ago

rancesol commented 1 year ago

Closes #552

Improve efficiency of the *_2h functions by replacing interp1d with splev and splrep.
Changed previously hard coded values in the *_2h functions into optional user defined arguments.
Added shape requirement to the validate_argument function in clmm/utils.py.

coveralls commented 1 year ago

Coverage: 100.0%. Remained the same when pulling 9d1e943e9683da181d68f08c2390ba268a1f3019 on rancesol:issue/552/improve_2h_functions into 06e06de5e085e7278e334eaa60fcbcbdfaebcff1 on LSSTDESC:main.

m-aguena commented 1 year ago

@rancesol the changes look good, it's just missing a unit test for the new functionality you added to validate_argument. Can you add it to tests/test_utils.py? Thanks