Bug in generate mock cluster when there is shape noise and pdz

LSSTDESC / CLMM

A Python library for performing galaxy cluster mass reconstruction from weak lensing observables

BSD 3-Clause "New" or "Revised" License

23 stars 18 forks source link

Bug in generate mock cluster when there is shape noise and pdz #580

Closed m-aguena closed 1 year ago

m-aguena commented 1 year ago

There is a bug when the arguments of generate_galaxy_catalog include:

shapenoise!=None,
photoz_sigma_unscaled!=None,
pzpdf_type='shared_bins'

(The replacement data is not generated with the same size of pdz!)

combet commented 1 year ago

Wow, nice catch @m-aguena! I reproduced the problem by pushing shapenoise to higher valies. Didn't encounter it with the values we have in the notebooks, so I missed it when reviewing the previous PR.