search

LSSTDESC / CLMM

A Python library for performing galaxy cluster mass reconstruction from weak lensing observables
BSD 3-Clause "New" or "Revised" License
23 stars 18 forks source link

Argument error_model not being used in make_radial_profile #586

Closed m-aguena closed 1 year ago

m-aguena commented 1 year ago

The dataops function make_radial_profile has an error_model argument but is not being used

sjdex commented 1 year ago

Argument needs to be removed from definition and references if I am correct.? Can you assign me this one.

sjdex commented 1 year ago

@m-aguena Can you review my previous comment

m-aguena commented 1 year ago

Actually, we want to have error_model being used inside make_radial_profile.

hsinfan1996 commented 1 year ago

Right now the default option is 'ste' in utils.py and the other option 'std' is not supported. Do we need to implement 'std' first?

m-aguena commented 1 year ago

Right now the default option is 'ste' in utils.py and the other option 'std' is not supported. Do we need to implement 'std' first?

We do have the other option implemented:

 if error_model == "ste":
     ...
elif error_model != "std":
    raise ....

This only fails if error_model is neither std nor ste

m-aguena commented 1 year ago

As it is just a small fix, I addressed it on PR #587