Issue/592/ccl v2.7 - Githubissues

LSSTDESC / CLMM

A Python library for performing galaxy cluster mass reconstruction from weak lensing observables

BSD 3-Clause "New" or "Revised" License

23 stars 18 forks source link

Issue/592/ccl v2.7 #593

Closed hsinfan1996 closed 1 year ago

coveralls commented 1 year ago

coverage: 100.0%. remained the same when pulling e16b8ce8b9a7cd81dd5cf9dd47bee8f4774d2bbc on issue/592/ccl_v2.7 into 09d54d09351b82aaffd6460dcc617f553acf5434 on main.

m-aguena commented 1 year ago

@hsinfan1996 I will put this here to remember the suggestion on the co-work:

[x] Add verification of CCL version XXX < v <YYY where the current CLMM implementation works

hsinfan1996 commented 1 year ago

@hsinfan1996 I will put this here to remember the suggestion on the co-work:

[x] Add verification of CCL version XXX < v <YYY where the current CLMM implementation works

@m-aguena Done. v2.7.1dev10 uses v3 api and we should address it in another PR. If we want to keep coverage at 100%, we use git checkout 1a351df instead of git checkout v2.7.0 for the check.

hsinfan1996 commented 1 year ago

@m-aguena Thank you.

hsinfan1996 commented 1 year ago

@m-aguena pylint is not passing. Should I add module docstring or # pylint: disable=missing-module-docstring to _ccl_supported_versions.py?

m-aguena commented 1 year ago

I just added a docstring to the file, thanks

hsinfan1996 commented 1 year ago

Is this one going to be merged soon? I kinda need this, though I can install from the branch.

m-aguena commented 1 year ago

It would be nice to have a second review. But you can marge it if no one replies by next week.

hsinfan1996 commented 1 year ago

It would be nice to have a second review. But you can marge it if no one replies by next week.

Yep. I see.