search

LSSTDESC / CLMM

A Python library for performing galaxy cluster mass reconstruction from weak lensing observables
BSD 3-Clause "New" or "Revised" License
23 stars 18 forks source link

NumCosmo v0.19 Compatibility #614

Closed hsinfan1996 closed 4 months ago

hsinfan1996 commented 5 months ago

Hi @vitenti Is NumCosmo v0.19 (and 0.18) still compatible with CLMM? I ran pytest on CLMM and and got AttributeError: type object 'HICosmo' has no attribute 'new_from_name'.

vitenti commented 5 months ago

The error was due to the usage of a deprecated constructor (new_from_name), I just create a PR with the fix, please take a look.

hsinfan1996 commented 5 months ago

@vitenti I was trying example 1 and 2 in CLMM/examples/NumCosmoand got AttributeError: 'GaussGammaT' object has no attribute 'y', but I think an earlier version of NC has had this issue already. Can you also fix this?

vitenti commented 5 months ago

Just updated these two Examples in the same PR. Please tell me there is something else not working properly.

hsinfan1996 commented 5 months ago

Just updated these two Examples in the same PR. Please tell me there is something else not working properly.

Thank you. I would like to confirm that after those changes the minimum compatible version is v0.19.

vitenti commented 5 months ago

It is mostly compatible with earlier versions, however, it is safer to require 0.19 minimum.

hsinfan1996 commented 5 months ago

It is mostly compatible with earlier versions, however, it is safer to require 0.19 minimum.

Yes, I find CLMM itself is compatible with v0.15 and above, but the updated notebooks requires v0.19+.