search

LSSTDESC / DC2-analysis

General analysis tools for the DC2 Data Set.
http://lsstdesc.org/DC2-analysis/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

Added new notebook with DIA Run2 introduction #126

Closed BrunoSanchez closed 4 years ago

BrunoSanchez commented 4 years ago

Adding notebook for mini sprint session with DIA

wmwv commented 4 years ago

@BrunoSanchez The image doesn't come through for me. Please add processing_schema.png to the tutorials directory.

BrunoSanchez commented 4 years ago

Sorry, now this should be OK.

wmwv commented 4 years ago

I think it's really important to add a note about how to screen the diaSrc for the sources that weren't flagged as obviously bad: e.g., SATURATED, INTERPOLATED. Looking at a raw diaSrc catalog without removing things already flagged to not be good creates a very confusing impression of the purity of the subtractions and detections.

BrunoSanchez commented 4 years ago

Check it now. I think most of the comments are resolved. Last comment regarding function uses, would like to see which specific parts should be functions, so I can make them informative.

reneehlozek commented 4 years ago

I think this is great @BrunoSanchez - and I'm sure there'll be more comments after the mini sprint today

reneehlozek commented 4 years ago

hi @BrunoSanchez and @wmwv, are the things in place to make these changes/updates given the recent progress?

BrunoSanchez commented 4 years ago

I am not sure. I think I have resolved everything requested. Michael still needs to approve on his side I think.

yymao commented 4 years ago

@BrunoSanchez I think we can merge this. Can you first clear the output of the notebook? See Step 5 of this instructions.