search

LSSTDESC / DC2-analysis

General analysis tools for the DC2 Data Set.
http://lsstdesc.org/DC2-analysis/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

U/jrbogart/pg truth #129

Closed JoanneBogart closed 4 years ago

JoanneBogart commented 4 years ago
  1. Add basic information about SQL and python module psycopg2 in new sections at the end of the intro notebook (postgres_object_1_intro)
  2. Add a new notebook explaining how to access star truth information via Postgres
JoanneBogart commented 4 years ago

Thanks @amit1rrr, good to know. In this case it's not so crucial since the changes are

  1. Added an entirely new notebook
  2. Made changes to an existing notebook almost entirely consisting of additional, purely expository sections at the end.
BrunoSanchez commented 4 years ago

Great additions

The notebooks look great. Only minor comments, just to be picky.

For the tutorial in SQL there is nothing to add, though I think that instead of being the last part (or appendix, fwiw) the SQL primer and psycopg module tutorial could potentially deserve a whole notebook or special readme file. I know this could be splitting things and confusing, but at the same time, they could easily be an postgres_0_sqlprimer_tutorial on its own.

Regarding the postgres truth, this is correct, and I think quite clear. Could be good to explain functions defined in the first group of code cells, just a few lines saying why and what are you defining this functions. If not, they make sense only once you actually use them, later on the tutorial. Queries could be multi line formatted, but this is my personal taste, specially when using JOIN or ORDER BY statements.