LSSTDESC / DC2-analysis

General analysis tools for the DC2 Data Set.
http://lsstdesc.org/DC2-analysis/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

Issue/138/xgal pz tutorial #145

Closed sschmidt23 closed 4 years ago

sschmidt23 commented 4 years ago

This PR addresses issue #138, I've updated the tutorial cells based on feedback from two people who I asked to work through the tutorial, and I am now happy with the tutorial.

There is still a sys.path.insert to load the newest version of the reader, but that single cell can be removed once gar-catalogs v0.19.0 is propagated to the desc-python kernel.

sschmidt23 commented 4 years ago

Ah, I should have noticed that use_only_master_attr, thanks for pointing this out!

I'll wait until desc-python is updated to v0.19.0, check that everything works, then delete the path before merging just to be sure it all works smoothly.

sschmidt23 commented 4 years ago

Ok, I added only_use_master_attr =False in the two locations and removed the local loading of gcr-catalogs, everything works now that desc-python points to v0.19.0. Everything looks ready to go.