search

LSSTDESC / DC2-analysis

General analysis tools for the DC2 Data Set.
http://lsstdesc.org/DC2-analysis/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

Add contributed notebook with added functionality beyond FOF matching #78

Closed rmandelb closed 4 years ago

rmandelb commented 5 years ago

This PR replaces #75 and includes updates carried out by @kakoon (HyeYun), as requested in the discussion on that PR.

kakoon commented 5 years ago

Thanks! sorry for the late reply. Is there something need to be done by me for this update?

Best, HyeYun Park

Stony Brook University Physics and Astronomy Brookhaven National Laboratory Large Synoptic Survey telescope Dark Energy Science Collaboration Office: (631) 344-4060 Mobile: (631) 605-0038

On Tue, Apr 2, 2019 at 7:53 PM Rachel Mandelbaum notifications@github.com wrote:

This PR replaces #75 https://github.com/LSSTDESC/DC2-analysis/pull/75 and includes updates carried out by @kakoon https://github.com/kakoon (HyeYun), as requested in the discussion on that PR.

You can view, comment on, or merge this pull request online at:

https://github.com/LSSTDESC/DC2-analysis/pull/78 Commit Summary

  • fof matching and making MLZ training/test inut files
  • Merge branch 'master' of https://github.com/LSSTDESC/DC2-analysis
  • adding mlz input catalog making on fof matching
  • adding mlz-blending to fof-matching
  • remove duplications of new content

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/DC2-analysis/pull/78, or mute the thread https://github.com/notifications/unsubscribe-auth/AMWwFJAJINbqLbaH62j4YzL07uxFE_81ks5vc-1fgaJpZM4cZVl5 .

reneehlozek commented 5 years ago

hi @kakoon, I think that this is ready for review now. I'll take a look, and check if @yymao has suggestions for another reviewer?

yymao commented 5 years ago

I'd like to suggest @jiwoncpark as a reviewer.

jiwoncpark commented 5 years ago

@yymao @kakoon Sure, I'd love to review this.

reneehlozek commented 5 years ago

hi @kakoon Just wanted to ping to see about the changes requested by @jiwoncpark for this PR?

reneehlozek commented 5 years ago

hi @kakoon, just another ping about this PR - are there more changes that @jiwoncpark should look at, or do you have a sense for when I should check again (I realise it is a busy time!)

kakoon commented 4 years ago

I am really sorry for the very very late reply, and thank you @jiwoncpark for the comments! I will change it accordingly and re-submit the note.

reneehlozek commented 4 years ago

hi @jiwoncpark are you happy with these changes? Can the PR be merged?