Issues/67 - Add Inspection Notebook for DC2 Object Tables

LSSTDESC / DC2-analysis

General analysis tools for the DC2 Data Set.

http://lsstdesc.org/DC2-analysis/

BSD 3-Clause "New" or "Revised" License

24 stars 15 forks source link

Issues/67 - Add Inspection Notebook for DC2 Object Tables #79

Closed wmwv closed 5 years ago

wmwv commented 5 years ago

This presents a visualization of some basic things for a DPDD-formatted Object Table catalog.

What calculations or visualizations should be added based on the Object Table?

Notes:

This version is for Run 1.2i, but can be easily changed by specifying a different catalog.
This version uses the Parquet file of the DPDD quantities, but could easily be changed to use the GCR catalog access model.

yymao commented 5 years ago

Move to the validation/ directory (see #42)?
If use base_dir is needed but not the actual catalog instance, you can do:
```
dpdd_parquet_dir = GCRCatalogs.get_catalog_config(catalog_name)['base_dir']
```
to save time on initiation of the catalog instance.

wmwv commented 5 years ago

@fjaviersanchez Could you take a look at this PR when you have the chance?

wmwv commented 5 years ago

Ah, yes the assets/Davenport_2014_MNRAS_440_3430_table1.txt is missing because it needs to be where this Notebook will be moved to, and I was intending for this to go to contributed. But, no, I didn't intend to submit a Notebook that doesn't work. I've made the link now ../contributed/assets/Davenport_2014_MNRAS_440_3430_table1.txt as this should work regardless of which subdirectory the Notebook ends up in.

On that note: @yymao @fjaviersanchez Can you vote on whether this Notebook should go into the tutorials subdirectory or a new validation subdirectory?

fjaviersanchez commented 5 years ago

I just noticed that #42 (which adds a validation directory and a couple of notebooks) is approved but not merged. I think that it would be best if this notebook were in the validation directory. However, I don't know if the easiest thing to do right now would be to just approve and merge this (so we avoid merging conflicts). After that, we can move it if that's fine with everyone.

wmwv commented 5 years ago

The should be no merge conflicts on the simple creation of a directory. I'm happy to rebase if necessary.

wmwv commented 5 years ago

@fjaviersanchez If you really want to make sure, you could just merge #42 and I'll make sure it's all good with that.

fjaviersanchez commented 5 years ago

Thanks! I just merged. Please go ahead and rebase and I'll go ahead and approve the PR.

wmwv commented 5 years ago

@fjaviersanchez Rebased, touched-up, and ready to be re-approved.