search

LSSTDESC / DC2-production

Configuration, production, validation specifications and tools for the DC2 Data Set.
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

update `columns_to_keep` in `trim_tract_cat.py` (fixes #296) #297

Closed yymao closed 6 years ago

yymao commented 6 years ago

This PR updates the columns_to_keep in the trim_tract_cat.py script. The hard-coded columns_to_keep is now removed, and is replaced by using the quantity modifiers defined in GCRCatalogs.dc2_object.DC2ObjectCatalog.

We also created a dummy class DummyDC2ObjectCatalog to make the script more readable.

This PR partly fixes #296 (as one still need to regenerate the trimmed files).

yymao commented 6 years ago

Thanks, @wmwv. Do you want me to help regenerate the trimmed files for 1.2i, or are you already on it?

wmwv commented 6 years ago

Re-generating now.

yymao commented 6 years ago

Sorry, didn't see this until now. I was trying to regenerate those trim files and found the script doesn't work, so I opened another PR #298.

yymao commented 6 years ago

BTW, @wmwv, you need to use GCRCatalogs 0.9.2 (current master) for the trim_tract_cat.py to work properly.

wmwv commented 6 years ago

I just did and it didn't work.

yymao commented 6 years ago

Which thing didn't work? The trim files you just generated seem to be working fine. (BTW, I'm happy to move this conversation to slack.)

wmwv commented 5 years ago

Resolved with updated trim_schema.yaml file. Thanks.