search

LSSTDESC / DC2-production

Configuration, production, validation specifications and tools for the DC2 Data Set.
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

fix the call to calibration dataset _photoCalib instead of _calib, an… #382

Closed johannct closed 4 years ago

johannct commented 4 years ago

…d remove the computation of mag, magerrs and SNR in case of _photoCalib; comment out two offending lines in write_gcr_to_parquet.py that are incompatible with pyarrow 0.13

johannct commented 4 years ago

Note that merge_source_cat.py had an exception handling for former _calib dataset, which I did not remove and into which I indented the lines that are now offending with _photoCalib API. We may want to homogeneize these two scripts, and we likely should give some more info in header docstring about when to use either. My understanding is that merge_source is for the Source table (table 6 in LSE-163) while merge_forced_source is for the ForcedSource table (table 7 in LSE-163) which only has 7 columns in the project document....

wmwv commented 4 years ago

And my apologies that this took me 2 months to look at!