search

LSSTDESC / DC2-production

Configuration, production, validation specifications and tools for the DC2 Data Set.
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

Truth match: switch to point-source mag for point sources and when cModel is not finite #431

Closed yymao closed 2 years ago

yymao commented 2 years ago

As discussed in this Slack thread, currently we use cModel mag from the object catalog to calculate magnitude difference when we generate the truth match catalog.

This PR updates this process, and switches to point-source magnitudes if

  1. the corresponding truth entry is not a galaxy; OR
  2. when cModel is not finite
wmwv commented 2 years ago

Does "1." take care of all of the instances of "2."?

yymao commented 2 years ago

@wmwv No. There do exist object entries who have non-finite cmodel mag but their nearest truth entry is galaxy type. This mostly happen for faint objects, so it's not related to the originally thread.

Among these objects (i.e., having non-finite cmodel mag but their nearest truth entry is galaxy type), about half of them don't have finite point-source mag either. The remaining has valid point-source mag that can be used to matching.

yymao commented 2 years ago

Thanks @wmwv. Points well taken. Code updated. Ready for re-review.