For the Run3.0i imSim testing at ALCF, Antonio encountered a number of sensor-visits that did not produce an output FITS file. Here's a plot of those sensor-visits, with the DDF boundary also shown:
The sensor-visits along the sides have tiny overlaps with the DDF, but there are no objects in the Run3.0i instance catalogs for those cases. For the sensor-visits where there are no objects to simulate, imSim simply exits and doesn't produce a FITS file. However, if the simulation starts from a checkpoint file, imSim should still produce the FITS file for the checkpointed data. That bug addressed in this imSim PR.
Most of the unfinished sensor-visits near the DDF corners actually lie outside the DDF, so should have been excluded from the .trim_sensors output. The current PR fixes this bug. Here's a plot showing the sensor-visits that should be simulated for visit 706993 (pink), as found by the revised code, and the ones that were included in the original test run that never finished (blue). R:2,2 S:0,0 is in both sets.
For the Run3.0i imSim testing at ALCF, Antonio encountered a number of sensor-visits that did not produce an output FITS file. Here's a plot of those sensor-visits, with the DDF boundary also shown:
The sensor-visits along the sides have tiny overlaps with the DDF, but there are no objects in the Run3.0i instance catalogs for those cases. For the sensor-visits where there are no objects to simulate, imSim simply exits and doesn't produce a FITS file. However, if the simulation starts from a checkpoint file, imSim should still produce the FITS file for the checkpointed data. That bug addressed in this imSim PR.
Most of the unfinished sensor-visits near the DDF corners actually lie outside the DDF, so should have been excluded from the
.trim_sensorsoutput. The current PR fixes this bug. Here's a plot showing the sensor-visits that should be simulated for visit 706993 (pink), as found by the revised code, and the ones that were included in the original test run that never finished (blue).R:2,2 S:0,0is in both sets.