search

LSSTDESC / ImageProcessingPipelines

Alert Production and Data Release image processing pipelines using the LSST Stack
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

post-merge review of dc2/run2.1(parsl) branch into master #159

Open heather999 opened 4 years ago

heather999 commented 4 years ago

As discussed on Slack, the parsl workflow has been merged to master before a proper review was performed. Comparing the pre-merge (7f262ef) and merge (50764c7815) commits allows us to take a peek at the changes: https://github.com/LSSTDESC/ImageProcessingPipelines/compare/7f262ef...50764c7815 So far all the updates seem to parsl-only - will also take a look at the SRS specific code to be sure nothing was updated by this merge.

jchiang87 commented 4 years ago

There appear to be commits from Ben going back to September 4, 2019, pre-dating 7f262ef .

heather999 commented 4 years ago

Yes, I know but 72262ef is the commit that was on HEAD of master before the merge. If you look at the compare linked in this issue, it does indeed show those commits going back to Sep 4 2019 - so I believe this allows us to view all the changes.

heather999 commented 4 years ago

Additionally, I've taken a look at the directories that contain SRS specific files including: