search

LSSTDESC / ImageProcessingPipelines

Alert Production and Data Release image processing pipelines using the LSST Stack
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Describe how to do forced photometry on DIAObjects #9

Closed heather999 closed 4 years ago

heather999 commented 6 years ago

From @drphilmarshall on January 18, 2018 23:20

The missing piece from Twinkles, now needs writing down in the Cookbook.

_Copied from original issue: LSSTDESC/DC2Repo#93

drphilmarshall commented 6 years ago

@SimonKrughoff @DominiqueFouchez I saw a mention in the Slack channel of a chart showing which parts of the DM DIA pipeline were not yet available - do you have that to hand? I'm wondering if forced photometry is one of them... Thanks!

SimonKrughoff commented 6 years ago

I don't have it right on hand, but the story was that I was worried about association. I'm not really anymore since we are focusing on DRP style DIAObjects. Forced photometry should be straightforward, but we may need to write a wrapper script that takes the correct objects to seed it.

drphilmarshall commented 6 years ago

Good :-) I think our approach to emulating the "Reprocessed Prompt" part of the DRP should be the same as the one we worked out for Twinkles, namely that we run DIA on each visit image independently, using the appropriate templateCoadd, to make the reprocessed DIASources for all the visit images taken to date, and then we make DIAObjects from the DIASources all in one go using the new DIAObject association code, and finally do Forced Photometry at these DIAObject positions. Right? Is this actually how reprocessing will be done? (The DPDD certainly makes it sound like this is what will happen.) Where should our to-be-written forcePhotometryOfDIAObjects.py script live? And is this already being written (or is due to be written) by someone on the Project?

SimonKrughoff commented 6 years ago

I think the process you say is a good approximation of how we will do things in operations. I don't know if anyone is thinking about the forced photometry part yet. I can check around.

It would be wonderful if we could write that script and issue a PR on pipe_tasks or ip_diffim.

drphilmarshall commented 6 years ago

I know, right? I long for a DESC-written DM-accepted Stack pull request. It would somehow show that we had arrived :-)

rbiswas4 commented 6 years ago

I saw a mention in the Slack channel of a chart showing which parts of the DM DIA pipeline were not yet available.

Is such a chart available somewhere ? That would be very useful to be able to see.

SimonKrughoff commented 6 years ago

Here is some discussion DIAObjects in the DPDD.