search

LSSTDESC / Monitor

Extract light curves for time-variable cosmological objects
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Move module directory; add unit test code; setup files; update README #5

Closed drphilmarshall closed 8 years ago

drphilmarshall commented 8 years ago

Looks good at first glance, but let's get travis CI on the case.

drphilmarshall commented 8 years ago

OK @jchiang87 , Travis CI is now set up. Can you please merge from master and edit .travis.yml so that it runs your tests? I got the setup help from this cookbook.

drphilmarshall commented 8 years ago

Hey! We haven't finished your code review yet!

drphilmarshall commented 8 years ago

Although I admit that your build is passing :-) Thanks very much Jim, this was a good exercise.

jchiang87 commented 8 years ago

Sorry! I misread the "from master" as "into master".

tony-johnson commented 8 years ago

At some point we should probably discuss the pros/cons of jenkins vs travis ci vs both.

Tony

On 02/02/2016 09:40 AM, Phil Marshall wrote:

OK @jchiang87 https://github.com/jchiang87 , Travis CI is now set up. Can you please merge from master and edit |.travis.yml| so that it runs your tests? I got the setup help from this cookbook https://docs.travis-ci.com/user/languages/python.

drphilmarshall commented 8 years ago

Yep - GitHub makes travis CI easy, so we just went with that for now. It'll choke on anything that depends on the stack though, I expect.

On Tue, Feb 2, 2016 at 11:14 AM, Tony Johnson notifications@github.com wrote:

At some point we should probably discuss the pros/cons of jenkins vs travis ci vs both.

Tony

On 02/02/2016 09:40 AM, Phil Marshall wrote:

OK @jchiang87 https://github.com/jchiang87 , Travis CI is now set up. Can you please merge from master and edit |.travis.yml| so that it runs your tests? I got the setup help from this cookbook https://docs.travis-ci.com/user/languages/python.

— Reply to this email directly or view it on GitHub https://github.com/DarkEnergyScienceCollaboration/Monitor/pull/5#issuecomment-178766081 .