search

LSSTDESC / SLRealizer

Catalog-level simulation of LSST DM stack measurements of gravitationally-lensed quasars.
https://slrealizer.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

Pull Request from DESC Writeup #25

Closed jennykim1016 closed 6 years ago

jennykim1016 commented 6 years ago

Happy Holidays and happy new year!

Sorry for the delay -- I was a little too much overwhelmed with my coursework during the fall quarter. Still, I've fixed all of the problems that we discussed at the end of the summer. Changes include

Please let me know if there is anything else I should fix! I will be changing grammatical mistakes and adding few more descriptions here and there too. Final DESC Note pdf file is in /doc/desc-0000-concept-slrealizer/main.pdf.

jennykim1016 commented 6 years ago

Oops, I just realized I also have to assign both of you as reviewers. Happy New Year! :)

drphilmarshall commented 6 years ago

Thanks very much, @jennykim1016 ! I'll do a quick check in this PR to make sure things look sensible, and then merge this into the issue/17/desc-note branch so that Mike and I can push edits to it if needed. The other PR that is open, should that also be merged into the issue/17/desc-note branch so that everything is on the same page? I'm guessing yes - I see a lot of commits in common between the two PRs.

jennykim1016 commented 6 years ago

Hello @drphilmarshall @mbaumer ! I just have one question about the workflow before I commit everything; I think beginning of the last summer, we said we would like to have a master branch that only contains the code and a descNote branch that contains both the code and the DESC note. Instead of this, should I put both the note and the code in the master branch and delete the desc-note branch? :)

drphilmarshall commented 6 years ago

No, let's stick to the plan: the point is that when the Note is ready for review by the SL working group, we want to be able to do that review using a GitHub pull request, from issue/17/descnote to master, all in the LSST DESC base repo. So, priority number 1 is getting the issue/17/descnote branch to look the way we all want it to. BTW I have some overdue admin to do, posting this project to the DESC confluence page! I'll do that now.

drphilmarshall commented 6 years ago

@jennykim1016 I just tried to compile your Note so I could take a look: neither of your desc-0000-slrealizer-concept folders contain a Makefile! I was also unable to compile either tex file with a straight call to pdflatex either: looks like there are some missing files. Can you please check this as well, by making a fresh clone and checking that the PDF for the tex file in the descWriteUp branch can be compiled? Thanks!

drphilmarshall commented 6 years ago

OK, I figured out which folders are which: I'll merge this, tidy up, and then we can work in the issue/17/desc-note branch. Thanks @jennykim1016 - and good luck with finals!