LSSTDESC / SLRealizer

Catalog-level simulation of LSST DM stack measurements of gravitationally-lensed quasars.
https://slrealizer.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

Refactor to subclass, streamline #29

Closed drphilmarshall closed 6 years ago

drphilmarshall commented 6 years ago

Hi @jiwoncpark !

When we met on Friday you said you were very close to finishing your re-factoring work: can you please submit a pull request to the master branch by Thursday 6pm? This will enable me to start the code review. I think you had also made progress on re-running the notebooks referred to in the DESC Note - great if you can submit those as well (with no outputs, as usual). We can close this issue when the PR is merged.

Thanks!

drphilmarshall commented 6 years ago

Revised deadline is Friday 12 noon PDT, following unavoidable class collision today. Hope it's going well, @jiwoncpark !

drphilmarshall commented 6 years ago

Update: this issue is very close to being thoroughly fixed in PR #32 ! :-)

jiwoncpark commented 6 years ago

Closing because PR #32 was merged!