Further update for #31, not yet ready to merge

LSSTDESC / SLRealizer

Catalog-level simulation of LSST DM stack measurements of gravitationally-lensed quasars.

https://slrealizer.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

0 stars 3 forks source link

Further update for #31, not yet ready to merge #32

Closed jiwoncpark closed 6 years ago

jiwoncpark commented 6 years ago

Everything I've written tests for runs now. Still writing tests for the SDSSRealizer subclass.

drphilmarshall commented 6 years ago

Good stuff! I'll carry on the review I started in #31. Looking fwd to seeing the re-org! :-)

jiwoncpark commented 6 years ago

With the exception of analytical ellipticities (second moments) and updating the classical ML results, which will be committed on Monday as we discussed, all comments have been reflected.

drphilmarshall commented 6 years ago

Great, thanks Ji Won! See you this afternoon.

jiwoncpark commented 6 years ago

All tasks completed (list of tasks can be accessed as closed issues at my fork, here). Everything should run. This PR doesn't include DL-specific commits.

drphilmarshall commented 6 years ago

PS. I see the GalSim installation is failing on travis - I'll issue that.