Working on Issue #12

[milanwilliams]

Hello @drphilmarshall,

I've updated the download method for the new SLTimer notebook.

Milan

[drphilmarshall]

And made a good start on some other methods too, I see! Good stuff, thank you.

Some quick notes:

• Let's follow the PEP8 standard for variable names, and make them as informative as we can. For example: display_light_curves, download_data, optimize_model('spline'), sample_model and so on (note the underscores and case).
• We'll probably want to split some methods into smaller ones. For example, report_time_delays is a short method that will be very useful. save_model (ie as a pickle) is another good one. Then, we can have higher level methods that call those lower level methods, so that we have multiple ways of using the code.

On Tue, Jun 21, 2016 at 4:56 PM, Milan M. Williams <notifications@github.com

wrote:

Hello @drphilmarshall https://github.com/drphilmarshall,

I've updated the download method for the new SLTimer notebook. https://github.com/milanwilliams/SLTimer/blob/master/notebooks/SLTimer_Tutorial.ipynb

Milan

You can view, comment on, or merge this pull request online at:

https://github.com/DarkEnergyScienceCollaboration/SLTimer/pull/17 Commit Summary

• Working download method
• Download test passes
• Working download method

File Changes

• M notebooks/PyCS_Tutorial.ipynb https://github.com/DarkEnergyScienceCollaboration/SLTimer/pull/17/files#diff-0 (14)
• A notebooks/SLTimer_Tutorial.ipynb https://github.com/DarkEnergyScienceCollaboration/SLTimer/pull/17/files#diff-1 (593)
• M python/desc/sltimer/SLTimer.py https://github.com/DarkEnergyScienceCollaboration/SLTimer/pull/17/files#diff-2 (72)
• M tests/test_SLTimer.py https://github.com/DarkEnergyScienceCollaboration/SLTimer/pull/17/files#diff-3 (20)

Patch Links:

- https://github.com/DarkEnergyScienceCollaboration/SLTimer/pull/17.patch

https://github.com/DarkEnergyScienceCollaboration/SLTimer/pull/17.diff

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DarkEnergyScienceCollaboration/SLTimer/pull/17, or mute the thread https://github.com/notifications/unsubscribe/AArY99WY9jJ7y1rxMa0gqHbRnKFYgb-rks5qOHoRgaJpZM4I7SXS .

[drphilmarshall]

Excellent! This looks good enough to me, @milanwilliams - nice work. I'll merge this, and then work through the notebook making some changes where I see them, and noting issues that need resolving. We can then move on from there.Thanks!