search

LSSTDESC / SLTimer

Time delay measurement from LSST light curves
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Reporting method, thoughts about storing 'samples', and better path in notebook #30

Closed drphilmarshall closed 8 years ago

drphilmarshall commented 8 years ago

The last part of this PR is in response to #29 (Binder needs python setup).

drphilmarshall commented 8 years ago

Experimental binder build is here...

drphilmarshall commented 8 years ago

... success! SLTimer tutorial now works fine in binder. Thanks @jchiang87 ! :-)

drphilmarshall commented 8 years ago

Hmm. Tests pass fine on my command line, but we must be importing things badly, as travis is having a hard time. Here's its error message:

Traceback (most recent call last): File "/home/travis/build/DarkEnergyScienceCollaboration/SLTimer/tests/test_SLTimer.py", line 23, in test_download_and_read_in self.timer.download(url) File "/home/travis/build/DarkEnergyScienceCollaboration/SLTimer/python/desc/sltimer/SLTimer.py", line 25, in download self.read_in(format=format) File "/home/travis/build/DarkEnergyScienceCollaboration/SLTimer/python/desc/sltimer/SLTimer.py", line 29, in read_in if format == 'rdb': self.lcs = read_in_rdb_data(self.datafile) File "/home/travis/build/DarkEnergyScienceCollaboration/SLTimer/python/desc/sltimer/IO.py", line 3, in read_in_rdb_data import pycs ImportError: No module named pycs

But the log from pip install -r requirements.txt shows no errors. I'm going to merge anyway, and issue the more general problem of how we import libraries...