search

LSSTDESC / SLTimer

Time delay measurement from LSST light curves
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

standardize the import statements #32

Closed jchiang87 closed 8 years ago

jchiang87 commented 8 years ago

I updated the import statements in IO.py and SLTimer.py to conform to the standards we've adopted from the DM team. In particular, I moved all of the import pycs statements to the top and removed them from the method bodies. Everything works for me when I run a local notebook, so I don't see anything similar to the problem mentioned in #31.

In the SLTimer_tutorial notebook, I would do

import desc.sltimer
timer = desc.sltimer.SLTimer()

I didn't change that for this PR since there might be other changes you want to make to the notebook.

drphilmarshall commented 8 years ago

Great, thanks Jim! That is much nicer. When @milanwilliams gets back we'll make sure it works for her too, but so far so good. I edited the notebook too, for completeness. Travis is failing on import pycs though, but that must be something to do with the way its being installed I guess. I don't know why that would be failing though, nothings changed in requirements.txt at this end. I'll merge this anyway, though. Thank you!