search

LSSTDESC / SLTimer

Time delay measurement from LSST light curves
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Write out sample time delays in slcosmo format #49

Closed chto closed 8 years ago

chto commented 8 years ago

I am going to create a function for compute_likelihood_simpleMC to save the samples and make it compatible with SLCosmo( i.e. store them in "tdc2samplefile" format).

drphilmarshall commented 8 years ago

Sounds good! You should issue these tasks separately, and make the issue titles as informative as possible - you can edit the issue title any time. Maybe make a separate issue for the r+i band only test, and then rename this one something like "Write out sample time delays in slcosmo format"? In general each issue should address just one issue (the exception is when you make an issue to host a set of related issues - this is called an "epic").

On Mon, Oct 10, 2016 at 5:30 PM, Chun Hao To <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I am going to restructure the code and add some function.

  1. I'll make the reading.py to be able to read data in given bands.
  2. create a function for compute_likelihood_simpleMC to save the samples and make it compatible with SLCosmo( i.e. store them in "tdc2samplefile" format)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DarkEnergyScienceCollaboration/SLTimer/issues/49, or mute the thread https://github.com/notifications/unsubscribe-auth/AArY9-Nc4bIimFb3ze0eVgRzbFWBeKhdks5qytiZgaJpZM4KTH2n .

chto commented 8 years ago

Thanks @drphilmarshall for very useful comment. I've changed my issues to make them more concrete. But I still have a question that am I able to assign an issue to myself?

drphilmarshall commented 8 years ago

Good good. I just changed your repo permissions, you should be able to assign/label/milestone the issues now.