API: simplify get_covariance_block methods and keep only the _for_sacc one

LSSTDESC / TJPCov

TJPCov is a general covariance calculator interface to be used within LSST DESC

https://tjpcov.readthedocs.io

MIT License

11 stars 1 forks source link

API: simplify get_covariance_block methods and keep only the _for_sacc one #69

Open carlosggarcia opened 1 year ago

carlosggarcia commented 1 year ago

At the moment, there are two public methods get_covariance_block and get_covariance_block_for_sacc. The former returns the covariance block as given by an external code (e.g. NaMaster), whereas the latter returns it like expected for the sacc file. I think this is going to be confusing and we should only keep as public method get_covariance_block_for_sacc.

felipeaoli commented 9 months ago

I am not sure what is the best decision here but now the get_covariance_block_for_sacc is implemented only in Fourier case. Any thoughts? Should I close this issue?