Closed mattkwiecien closed 1 year ago
Spun up a new conda environment with python 3.8 and installed tjpcov. Ran all the tests and all tests passed. Unless there's some edge cases I think we should be good to upgrade. @carlosggarcia @felipeaoli
So, FWIW, in RAIL we are requiring 3.8, 3.9 and 3.10 in our test matrix. I see that 3.11 is out there already. Might be worth testing against at least 3.9 and 3.10…
-e
On Apr 18, 2023, at 11:18 AM, Matthew Kwiecien @.***> wrote:
Spun up a new conda environment with python 3.8 and installed tjpcov. Ran all the tests and all tests passed. Unless there's some edge cases I think we should be good to upgrade. @carlosggarcia https://github.com/carlosggarcia @felipeaoli https://github.com/felipeaoli — Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/TJPCov/issues/85#issuecomment-1513609130, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRIGIWBNWJE65JKM3TQY63XB3LIXANCNFSM6AAAAAAXBK5RAU. You are receiving this because you are subscribed to this thread.
Good idea! I'll check those as well, best to stay up to date as much as we can
All tests still pass for 3.8, 3.9, 3.10, and 3.11. Will upgrade to 3.8 in a PR
SACC would like to update to require python 3.8 or above. Currently we require 3.7, but I don't think 3.8 would break anything.