LSSTDESC / TJPCov

TJPCov is a general covariance calculator interface to be used within LSST DESC
https://tjpcov.readthedocs.io
MIT License
11 stars 1 forks source link

Fixing known test issues and small test refactoring. #88

Closed mattkwiecien closed 1 year ago

mattkwiecien commented 1 year ago

Summary

Our tests don't consistently pass, which can be misleading for new contributors who find their new PR may lead to a failed build.

This was caused by 2 main issues, not completely tearing down the tests (e.g. cleanup) and a runtime error thrown by NaMaster that bubbles up the stack into our code.

With these changes I verified all tests pass (individually or all together) and all temporary files get cleaned up

NaMaster issue

Test changes

Code Changes

Build changes

mattkwiecien commented 1 year ago

Note for myself

DEPRECATION: --no-binary currently disables reading from the cache of locally built wheels. In the future --no-binary will not influence the wheel cache. pip 23.1 will enforce this behaviour change. A possible replacement is to use the --no-cache-dir option. You can use the flag --use-feature=no-binary-enable-wheel-cache to test the upcoming behaviour. Discussion can be found at https://github.com/pypa/pip/issues/11453