Updating TJPCov to require python >= 3.8

LSSTDESC / TJPCov

TJPCov is a general covariance calculator interface to be used within LSST DESC

https://tjpcov.readthedocs.io

MIT License

11 stars 1 forks source link

Updating TJPCov to require python >= 3.8 #90

Closed mattkwiecien closed 1 year ago

mattkwiecien commented 1 year ago

Closes #85

All tests pass. Also tested 3.9, 3.10, and 3.11.

Would be nice to include in our CI build tests for 3.9, 3.10, and 3.11 to ease future upgrades.

mattkwiecien commented 1 year ago

New sacc version broke some tests 🤣

mattkwiecien commented 1 year ago

Should be fixed!

joezuntz commented 1 year ago

Sorry!

mattkwiecien commented 1 year ago

Pushed a new v0.4.0 tag on this branch for new PyPI release. Lmk if we would rather do a patch, but requiring a new python version does seem like a "minor" update more than a patch

carlosggarcia commented 1 year ago

Based on https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api and https://softwareengineering.stackexchange.com/questions/345335/semantic-version-change-to-application-when-upgrading-libraries-involved, I'd say it's a patch since the user has not seen any change and we are fixing a bug in our code (introduced by the library update).