LSSTDESC / Twinkles

10 years. 6 filters. 1 tiny patch of sky. Thousands of time-variable cosmological distance probes.
MIT License
13 stars 12 forks source link

"Twinkles: An LSST DESC Data Challenge Pathfinder" - talk slides, discussion #270

Closed drphilmarshall closed 8 years ago

drphilmarshall commented 8 years ago

@DarkEnergyScienceCollaboration/twinkles

I started a slide set for our upcoming talk on July 8th, and then the Oxford meeting session a week and a half later. I put in a rough outline in the first 15 slides, and left the slides from our most recent "Twinkles as a pathfinder" talk (in April) later in the file. @jchiang87 @tony-johnson @richardxdubois @wmwv I think we should jump in to this and do what we can first (our names are mentioned!) and then use this thread to ping people we need new input from. What do you think?

drphilmarshall commented 8 years ago

Alright, we're off to a good start on this slide set, with some nice input from Jim on code development. Let's get some more content in there ASAP so we can see what we've got to work with!

jchiang87 commented 8 years ago

I added some slides on the comparisons with the input truth and fitting with sncosmo to the slide set ( @rbiswas4 could you have a look and comment please?) It would be great if we could get the intro slides filled with content from @wmwv, @drphilmarshall, and @richardxdubois. @tony-johnson are you planning to present the slides on the workflow engine stuff? If not, then I'll write those slides, otherwise I'll just leave them to you.

rbiswas4 commented 8 years ago

@jchiang87 That looks quite good! Here are a few comments:

Other possibilities:

I would be happy to help and probably have code lying around for some of this. The harder thing is to get all of it together. Some of this is in https://github.com/rbiswas4/sncosmo_lc_analysis. It might be good to try an offline/email discussion after tomorrow's meeting to list up things so that we can put ideas of what we would like together.

tony-johnson commented 8 years ago

Hi Jim, yes I will add slides on workflow, NERSC experience etc. Currently I can summarize the NERSC experience as "very frustrating":

heather999 commented 8 years ago

Concerning NERSC - while I agree aspects have been frustrating (as has been dealing with DMstack installs which is completely unrelated to NERSC) - it would be helpful to point out that we should take greater advantage of coordinating with the NERSC folks - who can be very helpful when directly poked. (actually the same can be said of DM!) The upcoming Cori downtime starting in late Aug is a bit of a concern.. the timing has not been on our side.

jchiang87 commented 8 years ago

@rbiswas4 Thanks for the comments! Here are some responses:

Generic comment about the slides: could you please add slide numbers on the slides. Useful to point to whenever we have remote attendance.

Done!

Could you please point me to the SNcosmo calls you are using to fit the light curves? Slide 21:

I actually went through as many as three iterations of fitting, but the calls were all essentially just this: https://github.com/jchiang87/desc_projects/blob/master/twinkles/refit_sncosmo.py#L33 The fits seem fairly sensitive to the redshift bounds, even when starting from the same initial value. If I set the bounds too wide (e.g., z in the range (0, 1)), I can get really poor fits. So I started out with z in (0.1, 0.4), and widened the bounds if the initial fit was pegged at either bound.

I don't understand the parameter n_sigma :

That's supposed to be an estimate of the quality of the fit in units of number of sigmas. I used an estimate that Phil gave me: n_sigma = sqrt(2chisq) - sqrt(2ndof-1). The vertical lines are upper bound cuts on n_sigma that I use to select different subsets of the data. The entries to the left of the blue line are the blue points in the subsequent plots.

The Delta T plot is interesting. While the difference is ~ milli-day :) and that is small I am surprised by the diagonal structure. This might have something to do with the guess_t0 moral prior, and would be interesting to figure out.

The Delta T units on the y-axis are actually supposed to be 1000s of days, so the diagonal guys are clearly mis-identifications.

I'll update my scripts to plot the other quantities you recommend. We can discuss further tomorrow.

rbiswas4 commented 8 years ago

@jchiang87 Q1. You are reading in a results pickle. Is this able to access the reference light curves and truths I was supplying? Q2. Do you have access to the ra, dec values measured in this pickle file? think this is both an interesting (kind of where we want to be) discussion and a potentially long one. Does it make sense to actually have some document in the documentation to keep track of it. (I don't have a problem with using issues simultaneously, I just feel like it would be nice to have a flat document (without being broken up into replies) to collect ideas and thoughts.

jchiang87 commented 8 years ago

@rbiswas4 The initial set of sncosmo fits just wrote out the fit parameters to an ascii file, and later I ran a version of this script to repackage those results into a DataFrame and also add the input truth parameters using your RefLightCurves.py code. I have the objectId in that DataFrame, so I've been resorting to db queries to get info like RA, Dec from the tables if I need them. All of the code to produce those plots is a bit disorganized and has been evolving. I plan to clean it up and reorganize it all into a sensible workflow so that I can rerun everything end-to-end, and then document it all. I hope I can find time to do that after Friday.

rbiswas4 commented 8 years ago

@jchiang87 OK, I want to suggest some changes to the fitting procedure (though they will not take care of the huge outliers). I will try to put that in a branch with a few comments, and you can implement it appropriately based on the exact contents/interface. (FYI, when I said documentation I was not talking about code documentation, but the documentation directory of Twinkles, more as a planning document)

We can discuss more about how to understand this tomorrow. But I think it might help to start from a simpler task

rbiswas4 commented 8 years ago

@jchiang87

The suggested changes are in https://github.com/rbiswas4/desc_projects/blob/changeSNCosmoModel/twinkles/refit_sncosmo.py The place where they start is at https://github.com/rbiswas4/desc_projects/blob/changeSNCosmoModel/twinkles/refit_sncosmo.py

L19

I will make some more changes to the model over the next few days.

jchiang87 commented 8 years ago

@rbiswas4 Thanks! Can you issue the pull-request?

rbiswas4 commented 8 years ago

ok. I was trying not to because it includes some lines of pseudo-code rather than real code ( because I do not know the internals of results), but I will issue one if you find it more convenient.

drphilmarshall commented 8 years ago

Alright! The slides are coming along, but need finishing this afternoon. We have the following action items:

Did I miss anything? Thanks!

drphilmarshall commented 8 years ago

Thanks all for your input! @jchiang87 @tony-johnson I put in some spacer slides, to help with our transitions tomorrow - see what you think. More comments welcome!

jbkalmbach commented 8 years ago

Lensed AGN image added to slide 33.

drphilmarshall commented 8 years ago

Cool, thanks @jbkalmbach! :-)

On Fri, Jul 8, 2016 at 1:35 AM, Bryce Kalmbach notifications@github.com wrote:

Lensed AGN image added to slide 33.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/270#issuecomment-231305509, or mute the thread https://github.com/notifications/unsubscribe/AArY9zBtoKVyg6PoC_wKL3V4G2Vl0ZEvks5qTgvogaJpZM4JCm_N .

drphilmarshall commented 8 years ago

I think this talk went well - closing out!