Open drphilmarshall opened 7 years ago
The lens galaxy matching shouldn't be a part of the sprinkler since we just run the example notebook once and create a new fits catalog of lens systems with the additional information we have added about the lens galaxies. At that point the sprinkler just uses this new catalog whenever you run it. I think we should certainly mention it in the mock catalog section of the notebook and maybe even summarize the example notebook adding some of the plots from there, but I don't think the code belongs in the sprinkler.
OK: I guess the Note should explain this, and instead present the matching as providing necessary additional information to what is present in the OM10 catalog. Thanks!
On Tue, May 23, 2017 at 9:39 PM, Bryce Kalmbach notifications@github.com wrote:
The lens galaxy matching shouldn't be a part of the sprinkler since we just run the example notebook once and create a new fits catalog of lens systems with the additional information we have added about the lens galaxies. At that point the sprinkler just uses this new catalog whenever you run it. I think we should certainly mention it in the mock catalog section of the notebook and maybe even summarize the example notebook adding some of the plots from there, but I don't think the code belongs in the sprinkler.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/Twinkles/pull/450#issuecomment-303615727, or mute the thread https://github.com/notifications/unsubscribe-auth/AArY9zSKTYAgHvnXVaPyUaMkUML8-njlks5r87R-gaJpZM4NeLRD .
This note is ready for comments. The Discussion and Conclusions section is kind of a set of bullet point response right now and any comments on the content there would be helpful before I write it out.
@jbkalmbach Here's an ipython notebook for us to write up the SL inputs work (showing the sprinkler in action, and the lens matching etc, #449). Can you take a look and maybe refine the section headings, do some subsectioning etc?
It looks to me as though we might need to refactor the sprinkler code so that it handles the lens galaxy matching - that stuff is just in an
example
notebook right now. What do you think?We won't merge this PR until we've finished writing the Note and the group has reviewed it.