LSSTDESC / Twinkles

10 years. 6 filters. 1 tiny patch of sky. Thousands of time-variable cosmological distance probes.
MIT License
13 stars 12 forks source link

LSST DESC Note: The Twinkles 1 Strong Lens Population #450

Open drphilmarshall opened 7 years ago

drphilmarshall commented 7 years ago

@jbkalmbach Here's an ipython notebook for us to write up the SL inputs work (showing the sprinkler in action, and the lens matching etc, #449). Can you take a look and maybe refine the section headings, do some subsectioning etc?

It looks to me as though we might need to refactor the sprinkler code so that it handles the lens galaxy matching - that stuff is just in an example notebook right now. What do you think?

We won't merge this PR until we've finished writing the Note and the group has reviewed it.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 41.35% when pulling f06cbfc1357a77e0668030025dd647c49fd23577 on issue/449/twinkles1-sl-pop-note into e0da20abb29c9d7353ad6397e06a2b51e8605e9f on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 41.35% when pulling d82eb00e1722cdf75af1dd0db9a1275ceb364d73 on issue/449/twinkles1-sl-pop-note into e0da20abb29c9d7353ad6397e06a2b51e8605e9f on master.

jbkalmbach commented 7 years ago

The lens galaxy matching shouldn't be a part of the sprinkler since we just run the example notebook once and create a new fits catalog of lens systems with the additional information we have added about the lens galaxies. At that point the sprinkler just uses this new catalog whenever you run it. I think we should certainly mention it in the mock catalog section of the notebook and maybe even summarize the example notebook adding some of the plots from there, but I don't think the code belongs in the sprinkler.

drphilmarshall commented 7 years ago

OK: I guess the Note should explain this, and instead present the matching as providing necessary additional information to what is present in the OM10 catalog. Thanks!

On Tue, May 23, 2017 at 9:39 PM, Bryce Kalmbach notifications@github.com wrote:

The lens galaxy matching shouldn't be a part of the sprinkler since we just run the example notebook once and create a new fits catalog of lens systems with the additional information we have added about the lens galaxies. At that point the sprinkler just uses this new catalog whenever you run it. I think we should certainly mention it in the mock catalog section of the notebook and maybe even summarize the example notebook adding some of the plots from there, but I don't think the code belongs in the sprinkler.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/Twinkles/pull/450#issuecomment-303615727, or mute the thread https://github.com/notifications/unsubscribe-auth/AArY9zSKTYAgHvnXVaPyUaMkUML8-njlks5r87R-gaJpZM4NeLRD .

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 41.35% when pulling f1794204e66c85b0a72b0ac52fc548b6e45e8e77 on issue/449/twinkles1-sl-pop-note into e0da20abb29c9d7353ad6397e06a2b51e8605e9f on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 41.35% when pulling 5f5c66412c5cd02253585bd3582c5804abe146c5 on issue/449/twinkles1-sl-pop-note into e0da20abb29c9d7353ad6397e06a2b51e8605e9f on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 41.35% when pulling f299caed86366751da0126adc69d36726cec7ef0 on issue/449/twinkles1-sl-pop-note into e0da20abb29c9d7353ad6397e06a2b51e8605e9f on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 41.35% when pulling d461539499db9ec94d9c49f10c61a0b24fac9fdf on issue/449/twinkles1-sl-pop-note into e0da20abb29c9d7353ad6397e06a2b51e8605e9f on master.

jbkalmbach commented 7 years ago

This note is ready for comments. The Discussion and Conclusions section is kind of a set of bullet point response right now and any comments on the content there would be helpful before I write it out.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 41.35% when pulling cc5d7c69cbe982230bcf855c2e858a6733402a2a on issue/449/twinkles1-sl-pop-note into e0da20abb29c9d7353ad6397e06a2b51e8605e9f on master.