search

LSSTDESC / Twinkles

10 years. 6 filters. 1 tiny patch of sky. Thousands of time-variable cosmological distance probes.
MIT License
13 stars 12 forks source link

U/danielsf/instance catalog production/181031 #483

Closed danielsf closed 5 years ago

danielsf commented 5 years ago

This PR updates sprinkler.py to reflect the new column names in the Twinkles data files.

It also increases the speed of the sprinkler by 1) only calling find_lens_candidates if self.cached_sprinkling == False 2) appending rows to updated_catalog in a single batched call to np.append, rather than multiple single-row calls.

danielsf commented 5 years ago

No. We have not used the ic_validation code. Can you point me to an example of how it should be run?

jbkalmbach commented 5 years ago

You should be able to use the script in the utils folder. Running from the command line should work as:

python run_validation.py /path/to/catalogs obsHistId /path/to/SN/SEDs

danielsf commented 5 years ago

@jbkalmbach Thanks for the nudge. I had introduced a bug such that the sprinkler wasn't adding the lens galaxy for a supernova unless the supernova itself was visible. Your script caught it. Good job.

Happy Thanksgiving!

danielsf commented 5 years ago

@jbkalmbach This is the branch I was talking about, in case you forgot

danielsf commented 5 years ago

This is being supplanted by

https://github.com/LSSTDESC/Twinkles/pull/495