search

LSSTDESC / WeakLensingDeblending

Weak lensing fast simulations and analysis of blended objects.
http://weaklensingdeblending.readthedocs.io/en/latest/index.html
Other
14 stars 13 forks source link

id -> galtileid? #11

Closed jmeyers314 closed 8 years ago

jmeyers314 commented 8 years ago

Hi David,

I'm looking through some of this code to try and figure out why Ismael's getting weird results. I came across this line: https://github.com/DarkEnergyScienceCollaboration/WeakLensingDeblending/blob/master/descwl/catalog.py#L87

I'm guessing this should be

if self.only_id and entry['galtileid'] not in self.only_id:

but wanted to make sure I'm interpreting your intentions right. Can you confirm?

dkirkby commented 8 years ago

Yes! (and the same two lines below). I renamed 'id' to 'galtileid' at some point and obviously didn't test this option after the change. Can you make a PR with just this fix or should I do it?