search

LSSTDESC / WeakLensingDeblending

Weak lensing fast simulations and analysis of blended objects.
http://weaklensingdeblending.readthedocs.io/en/latest/index.html
Other
14 stars 13 forks source link

Merge for bias calculations. #16

Closed ismael-mendoza closed 8 years ago

ismael-mendoza commented 8 years ago

Pull request to merge that includes Fisher Formalism Bias calculations.

dkirkby commented 8 years ago

It looks like you changed the file mode of everything under notebooks/ from 100644 to 100755, i.e., adding the execute bit. Was that intentional? I don't think this bit should be set.

dkirkby commented 8 years ago

Have you checked that the TutorialIntroduction notebook runs and gives the same output in your branch?

ismael-mendoza commented 8 years ago

Just ran the tutorial and I get the same output in my branch. Should be ready to merge!

dkirkby commented 8 years ago

It doesn't look like your file permission changes had any effect. Can you try this recipe?

ismael-mendoza commented 8 years ago

Recipe does not seem to work. Or maybe I am missing something when I execute it. Thanks! screen shot 2016-08-09 at 11 13 10 am

ismael-mendoza commented 8 years ago

I think I just got it by running: 

 git update-index --chmod=-x *

Inside the notebooks/ directory

dkirkby commented 8 years ago

You missed notebooks/.gitignore (since * ignores dot files).

ismael-mendoza commented 8 years ago

Thanks! just changed it, hadn't realized this.

dkirkby commented 8 years ago

I have just done the merge, but there are some problems with the sphinx docs that I am troubleshooting now...

dkirkby commented 8 years ago

@ismael2395 You added the following import to render.py which is causing problems:

import matplotlib.pyplot as plt

It looks like this is never used so I can safely remove it?

ismael-mendoza commented 8 years ago

I think you can safely remove that line - I probably added this to debug at some point.