search

LSSTDESC / augur

DESC forecasting and inference validation tool
MIT License
4 stars 2 forks source link

ENH first commit #6

Closed beckermr closed 4 years ago

beckermr commented 4 years ago

cc @slosar

beckermr commented 4 years ago

This file may be of use: https://github.com/LSSTDESC/firecrown/blob/master/examples/desc_srd_v1/generate_srd_data.py#L3

slosar commented 4 years ago

Ok, I'll work on this next week, but I knew you will come with test. But what is an appropriate test for a code like this? Just run the entire code with a known input file and compare the sacc output? It seems you would want a bit more granularity, but I'm really at loss here. Should there be a test for the generate function or parser function?

slosar commented 4 years ago

I think I answered most of your comments and culled some code using firecrown's build_sacc_data. Now I need to do tests -- I now see how it is done in firecrown...

slosar commented 4 years ago

Ok, now with seven tests that pass if you run pytest in the root directory.

slosar commented 4 years ago

CI integrations with GH actions now working.