search

LSSTDESC / augur

DESC forecasting and inference validation tool
MIT License
3 stars 2 forks source link

Adding downstream accuracy CCL params #64

Closed fjaviersanchez closed 2 weeks ago

fjaviersanchez commented 2 weeks ago

This PR addresses #56, and adds the ability to pass along CCL accuracy parameters through augur. I still have to check whether these are passed downstream to firecrown (I suspect so, but not 100% sure).

arthurmloureiro commented 2 weeks ago

@fjaviersanchez do we know if these are passed to Firecrown?

fjaviersanchez commented 2 weeks ago

No. Not for sure. I need confirmation from @marcpaterno and/or @vitenti .

fjaviersanchez commented 2 weeks ago

I am suspecting that since it will be in the same session of ccl it won't change those values, but can't tell if that's always the case.

arthurmloureiro commented 2 weeks ago

I think we also this into Analyse in case a likelihood is passed.

I am working on #60 to make that easier for the user. I think eventually we will shift towards only using pre-made firecrown likelihoods as this allows us make use of firecrown's .get_data_vector() method and similar stuff.