add select/unselect all buttons

LSSTDESC / desc-data-portal

LSST DESC Data Portal web app and the associated documentation and example notebooks.

https://data.lsstdesc.org

BSD 3-Clause "New" or "Revised" License

7 stars 2 forks source link

add select/unselect all buttons #49

Closed yymao closed 3 years ago

yymao commented 3 years ago

Fixes #47.

I can't test this locally so I am not sure if it actually works. I am opening as a draft PR for now. @heather999 can you push this branch to the test site?

heather999 commented 3 years ago

Now deployed to dev. I see the buttons (maybe they need to be slid over to the right).

JoanneBogart commented 3 years ago

This is looking good! But I still have some nits to pick:

Text starting "Choose the files.." should be left-adjusted (currently appears to be centered)
I would revise that text slightly to read

Choose the files you wish to download, then click the "Transfer" button at the bottom of the page.

or use some other way to make Transfer stand out a bit.

yymao commented 3 years ago

I've implemented the remaining two items in #1. This PR now fixes #1.

heather999 commented 3 years ago

deployed to dev portal, but does not seem to be working. I'm going to clear my cache and try again and then offer more details.

heather999 commented 3 years ago

Same odd behavior after clearing my cache:

Clicking Select Example Subset results in temporarily selecting the checkboxes, the total download appears as NaN but then the page reloads and the selection is lost.
Clicking Select All, leads directly to transfer I'll take a look at the routing